feat: add Discussion column linking each proposal to its forum thread - #75
Closed
dak-agent[bot] wants to merge 1 commit into
Closed
feat: add Discussion column linking each proposal to its forum thread#75dak-agent[bot] wants to merge 1 commit into
dak-agent[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
dak-agent
Bot
requested review from
Baltoli,
QEDK,
keone,
kjcamann and
pdobacz
as code owners
August 2, 2026 21:22
Collaborator
|
Does not render well on mid-size / mobile screens and looks pretty awful, furthermore discussion links are already present on MIP pages as icons and table rows, hence redundant, closing as not done, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new Discussion column to both the MIPs and MRCs tables on mips.monad.xyz. Each row now has a Forum link that opens the proposal's discussion thread on the Monad forum.
How
discussions-to:front-matter field (e.g. MIP-8 →https://forum.monad.xyz/t/mip-8-page-ified-storage-state/407), so every row points at its own thread.discussions-to:set (currently only MIP-2), the cell falls back to the MIPs forum category:https://forum.monad.xyz/c/mips/8.target="_blank" rel="noopener noreferrer") and are ignored by the row-click handler, so clicking Forum goes to the forum while clicking anywhere else in the row still opens the proposal.Details
<th>Discussion</th>header + cell added to both the MIPs and MRCs tables.@media (min-width: 700px)) to 6 columns (7 / 33 / 22 / 12 / 13 / 13 %) and bumped the mobilemin-widthto1000pxto accommodate the extra column..discussion-linkstyle (label + external-link glyph, kept on one line).Verification
CI runs
jekyll buildon this PR, which validates the Liquid renders. Note that GitHub Pages deploy only runs onmain, so the live site updates once this is merged.