Skip to content

chore(compass-test-server): switch to shared mongodb-server-log-checker package#7890

Merged
paula-stacho merged 2 commits intomainfrom
use-shared-mongodb-server-log-checker
Mar 24, 2026
Merged

chore(compass-test-server): switch to shared mongodb-server-log-checker package#7890
paula-stacho merged 2 commits intomainfrom
use-shared-mongodb-server-log-checker

Conversation

@addaleax
Copy link
Copy Markdown
Collaborator

Refs: #7845 (comment)

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax addaleax requested a review from a team as a code owner March 19, 2026 14:31
@addaleax addaleax requested review from Copilot and gribnoysup March 19, 2026 14:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates @mongodb-js/compass-test-server to rely on the shared @mongodb-js/mongodb-server-log-checker package instead of maintaining an in-repo server log checker implementation.

Changes:

  • Removed the local ServerLogsChecker/WarningFilter implementation from compass-test-server.
  • Re-exported ServerLogsChecker and WarningFilter from @mongodb-js/mongodb-server-log-checker.
  • Added the new dependency and updated the lockfile accordingly.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/compass-test-server/src/server-logs-checker.ts Removed in-package server log checker implementation in favor of shared package.
packages/compass-test-server/src/index.ts Switches exports to re-export ServerLogsChecker / WarningFilter from the shared package.
packages/compass-test-server/package.json Adds @mongodb-js/mongodb-server-log-checker dependency.
package-lock.json Locks the new dependency and updates workspace dependency graph.

@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Mar 19, 2026
@paula-stacho
Copy link
Copy Markdown
Collaborator

fyi @gribnoysup this should prevent the failures we've seen in EOL tests as the id will be on the list of default exceptions

@paula-stacho paula-stacho self-requested a review March 19, 2026 15:20
Copy link
Copy Markdown
Collaborator

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, double checked the list and we have everything included. thank you @addaleax !

@addaleax
Copy link
Copy Markdown
Collaborator Author

@paula-stacho We may also want to pull this one in: mongodb-js/devtools-shared#627

The purpose is to make it usable in mongosh, but this is also a broad category of warnings we'll want to ignore for Compass too

@paula-stacho paula-stacho merged commit a7e5a72 into main Mar 24, 2026
54 of 56 checks passed
@paula-stacho paula-stacho deleted the use-shared-mongodb-server-log-checker branch March 24, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants