chore(compass-test-server): switch to shared mongodb-server-log-checker package#7890
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates @mongodb-js/compass-test-server to rely on the shared @mongodb-js/mongodb-server-log-checker package instead of maintaining an in-repo server log checker implementation.
Changes:
- Removed the local
ServerLogsChecker/WarningFilterimplementation fromcompass-test-server. - Re-exported
ServerLogsCheckerandWarningFilterfrom@mongodb-js/mongodb-server-log-checker. - Added the new dependency and updated the lockfile accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-test-server/src/server-logs-checker.ts | Removed in-package server log checker implementation in favor of shared package. |
| packages/compass-test-server/src/index.ts | Switches exports to re-export ServerLogsChecker / WarningFilter from the shared package. |
| packages/compass-test-server/package.json | Adds @mongodb-js/mongodb-server-log-checker dependency. |
| package-lock.json | Locks the new dependency and updates workspace dependency graph. |
|
fyi @gribnoysup this should prevent the failures we've seen in EOL tests as the id will be on the list of default exceptions |
There was a problem hiding this comment.
looks good, double checked the list and we have everything included. thank you @addaleax !
|
@paula-stacho We may also want to pull this one in: mongodb-js/devtools-shared#627 The purpose is to make it usable in mongosh, but this is also a broad category of warnings we'll want to ignore for Compass too |
Refs: #7845 (comment)
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes