Skip to content

test(compass-e2e): try enabling bidi for e2e COMPASS-10536 #7895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbbeeken wants to merge 5 commits into from
Closed

test(compass-e2e): try enabling bidi for e2e COMPASS-10536 #7895

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93b0496
test(compass-e2e): try enabling bidi for e2e
nbbeeken Mar 21, 2026
e003997
try bidi for electron
nbbeeken Mar 23, 2026
0cffa1a
Revert "test(compass-e2e): try enabling bidi for e2e"
nbbeeken Mar 23, 2026
70c91a5
Reapply "test(compass-e2e): try enabling bidi for e2e"
nbbeeken Mar 23, 2026
59eb7d8
Revert "try bidi for electron"
nbbeeken Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/compass-e2e-tests/helpers/compass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,7 @@ export async function startBrowser(

const options: WebdriverIO.RemoteConfig = {
capabilities: {
webSocketUrl: true,
browserName,
Comment on lines 854 to 856
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webSocketUrl: true is applied unconditionally for all web E2E sessions (including the Firefox variants in Evergreen). Since this is described as an experiment to “try enabling BiDi”, consider gating it behind an explicit CLI flag/env var (defaulting off) and only enabling when the selected driver/browser version is known to support the webSocketUrl capability, so CI can fall back to classic behavior if needed.

Copilot uses AI. Check for mistakes.
...(context.browserVersion && {
browserVersion: context.browserVersion,
Expand Down
Loading