Skip to content

fix(data-service): remove compass connectivity check via ping COMPASS-9455 #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbbeeken merged 9 commits into from
Apr 2, 2026
Merged

fix(data-service): remove compass connectivity check via ping COMPASS-9455 #7897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
22a585d
COMPASS-9455: remove compass ping on connect
nbbeeken Mar 23, 2026
8deddbc
test: remove old test
nbbeeken Mar 23, 2026
462cb2d
lint
nbbeeken Mar 23, 2026
a54e01a
wip
nbbeeken Apr 1, 2026
dc4817d
update @mongodb-js/devtools-connect
nbbeeken Apr 2, 2026
0700ce9
rm .only
nbbeeken Apr 2, 2026
a3f8384
actually bump devtools-connect
nbbeeken Apr 2, 2026
80d297b
de-dupe devtools-connect
nbbeeken Apr 2, 2026
6962c0a
title
nbbeeken Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 6 additions & 216 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/atlas-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"@mongodb-js/compass-user-data": "^0.18.0",
"@mongodb-js/compass-utils": "^0.9.31",
"@mongodb-js/connection-info": "^0.27.2",
"@mongodb-js/devtools-connect": "^3.14.13",
"@mongodb-js/devtools-connect": "^3.15.0",
"@mongodb-js/devtools-proxy-support": "^0.7.6",
"@mongodb-js/oidc-plugin": "^2.0.4",
"compass-preferences-model": "^2.75.0",
Expand Down
12 changes: 6 additions & 6 deletions packages/compass-e2e-tests/tests/connection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,20 +309,20 @@ describe('Connection string', function () {
const connectionError = await browser
.$(Selectors.ConnectionToastErrorText)
.getText();
expect(connectionError).to.equal('Authentication failed.');
expect(connectionError).to.include('Authentication failed.');

const errorMessage = await browser
.$(Selectors.ConnectionToastErrorText)
.getText();
expect(errorMessage).to.equal('Authentication failed.');
expect(errorMessage).to.include('Authentication failed.');

// click the review button in the toast
await browser.clickVisible(Selectors.ConnectionToastErrorReviewButton);
await browser.waitForOpenModal(Selectors.ConnectionModal);
const errorText = await browser
.$(Selectors.ConnectionFormErrorMessage)
.getText();
expect(errorText).to.equal('Authentication failed.');
expect(errorText).to.include('Authentication failed.');

// close the modal
await browser.clickVisible(Selectors.ConnectionModalCloseButton);
Expand Down Expand Up @@ -943,7 +943,7 @@ describe('Connection form', function () {
connectionName: connection1Name,
},
toastErrorTitle: connection1Name,
toastErrorText: `Authentication failed.`,
toastErrorText: 'Authentication failed.',
},
{
state: {
Expand Down Expand Up @@ -999,7 +999,7 @@ describe('Connection form', function () {
const errorMessage = await browser
.$(`${toastSelector} ${Selectors.ConnectionToastErrorText}`)
.getText();
expect(errorMessage).to.equal(expected.toastErrorText);
expect(errorMessage).to.include(expected.toastErrorText);

// click the review button in the toast
await browser.clickVisible(
Expand All @@ -1014,7 +1014,7 @@ describe('Connection form', function () {
const errorText = await browser
.$(Selectors.ConnectionFormErrorMessage)
.getText();
expect(errorText).to.equal(expected.toastErrorText);
expect(errorText).to.include(expected.toastErrorText);

const state = await browser.getConnectFormState();
expect(state.hosts).to.deep.equal(expected.state.hosts);
Expand Down
1 change: 0 additions & 1 deletion packages/compass-web/polyfills/@mongodb-js/devtools-connect/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export async function connectMongoClient(
delete options.oidc;
delete options.parentState;
delete options.parentHandle;
options.__skipPingOnConnect = true;
const client = new MongoClient(url, options);
await client.connect();
return {
Expand Down
2 changes: 1 addition & 1 deletion packages/data-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
},
"dependencies": {
"@mongodb-js/compass-utils": "^0.9.31",
"@mongodb-js/devtools-connect": "^3.14.13",
"@mongodb-js/devtools-connect": "^3.15.0",
"@mongodb-js/devtools-proxy-support": "^0.7.6",
"bson": "^7.2.0",
"debug": "^4.3.4",
Expand Down
Loading
Loading