Skip to content

chore: add rule on shared components #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paula-stacho wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

chore: add rule on shared components #7900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441c805
chore: add rule on shared components
paula-stacho Mar 24, 2026
c83688a
Update AGENTS.md
paula-stacho Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ export default connect((state) => ({
}))(MyComponent);
```

### Shared components should have a single look and feel

Shared components in `packages/compass-components` define the baseline design system.
Avoid adding new props or configuration options to a shared component to satisfy a one-off request for a visual change. If a new feature requires a different look and feel, bring up the discrepancy and ask for feedback on how to move forward.

## Commits and pull requests

When drafting git commit messages or GitHub pull requests for this repository, follow the conventions described in `COMMIT_MESSAGES.md`.
Loading