Open
Conversation
lerouxb
added
the
no-title-validation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository agent guidance to reduce time spent rediscovering how to run and focus tests in this monorepo.
Changes:
- Add “Running tests” section to AGENTS.md with examples for running a single spec file in a workspace/package.
- Add guidance for filtering tests by description using a
--grepargument.
gribnoysup
reviewed
Mar 25, 2026
| npm test -- --grep="test description pattern" | ||
| ``` | ||
|
|
||
| Note: Use `--grep="pattern"` with equals sign, not `--grep "pattern"` with a space. |
Collaborator
There was a problem hiding this comment.
FWIW this is a bug in our shared mocha config
Member
Author
There was a problem hiding this comment.
yeah. But I think we can fix that separately - the change to the AGENTS.md file would be one character but this would still work even after we fix it anyway.
Collaborator
There was a problem hiding this comment.
if we have a ticket to fix that we can add a note to clean this up
gribnoysup
approved these changes
Mar 27, 2026
Anemy
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that claude kept figuring out how to focus a test again and again, grepping things all over and spending lots of time on it.
So I asked it to just update the AGENTS.md file to tell itself how to do that in future. Let's see if it helps?
Coincidentally it started with
npm test -- --grep "test description pattern"(note the space aftergrep) which doesn't work. I pointed out that it doesn't work and asked it to figure out how to fix it and it realised you need the=. This is actually a thing I have run into again and again myself, so if anything this is useful documentation for humans.