fix(e2e-tests): increase timeout for preferences and wait for modal to show up COMPASS-10529#7926
Draft
fix(e2e-tests): increase timeout for preferences and wait for modal to show up COMPASS-10529#7926
Conversation
mabaasit
commented
Mar 30, 2026
| const waitUntilOptions = { | ||
| timeoutMsg: 'Preferences are not available', | ||
| interval: 3000, | ||
| interval: 5000, |
Collaborator
Author
There was a problem hiding this comment.
I am still not sure why tests (test suite 2) are failing for firefox only to set the preferences. Trying to bump this value to test it
Collaborator
There was a problem hiding this comment.
This is check interval (how often this wait fn will run), not the timeout, default timeout we have is really big though, so idk if increasing it even more will do anything
lerouxb
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes