feat: truncate long strings data browsing VSCODE-745#1252
Open
tculig wants to merge 8 commits intomongodb-js:mainfrom
Open
feat: truncate long strings data browsing VSCODE-745#1252tculig wants to merge 8 commits intomongodb-js:mainfrom
tculig wants to merge 8 commits intomongodb-js:mainfrom
Conversation
226406b to
94682a1
Compare
Contributor
|
could we use text-overflow: ellipsis;instead? https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/text-overflow |
Member
|
When you copy to clipboard it should copy the whole document, not the truncated strings. |
lerouxb
reviewed
Mar 2, 2026
| truncationMapRef.current, | ||
| expandedPathsRef.current, | ||
| ); | ||
| const formatted = toJSString(truncated) ?? ''; |
Member
There was a problem hiding this comment.
Remember that we also use documentString in handleCopy below. And copy should copy the whole document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/VSCODE-745
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes