fix: show error message if connection closed VSCODE-770#1299
Merged
tculig merged 4 commits intomongodb-js:mainfrom Apr 2, 2026
Merged
fix: show error message if connection closed VSCODE-770#1299tculig merged 4 commits intomongodb-js:mainfrom
tculig merged 4 commits intomongodb-js:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the data browser webview behavior when the underlying MongoDB connection is no longer active (e.g., disconnected or switched), ensuring a clear error is surfaced instead of attempting operations on a stale connection.
Changes:
- Track the active connection id per opened data-browsing webview panel and validate it on incoming webview messages.
- Return appropriate webview error messages (documents / totalCount) or VS Code modal errors (mutations) when the panel’s connection no longer matches the active connection.
- Add a dedicated test suite covering connection-mismatch behavior (VSCODE-770).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/views/dataBrowsingController.ts | Stores per-panel connection id and rejects data-related webview commands when the active connection has changed/closed. |
| src/test/suite/views/dataBrowsingController.test.ts | Adds tests validating the new connection-mismatch handling paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anemy
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.mongodb.org/browse/VSCODE-770
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes