Fix '--reset' and '--no-load' args combination - #17
Open
v1k1nghawk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a logical point of view, it is not possible to specify '--reset' and '--no-load' arguments at the same time. The current py-tpcc code state allows this, causing the database to be dropped, the new database not being created, and the run phase starting on an non-existent database, resulting in a waterfall of errors. Based on this, it is proposed to introduce a check for the presence of a combination of these two arguments.
Command:
time ./tpcc.py --config mconfig --warehouses 1 --clients 1 --no-load --reset mongodbOriginal behavior:
Log file:
Output:
Suggested behavior: