CLOUDP-356692: Support for exporting Atlas resources using auto-generated CRDs#175
CLOUDP-356692: Support for exporting Atlas resources using auto-generated CRDs#175
Conversation
| if opts.operatorVersion == "" { | ||
| image := operatorDeployment.Spec.Template.Spec.Containers[0].Image | ||
| hasContainerImageRepo := strings.Contains(image, containerImage + ":") | ||
| hasContainerImageRepo := strings.Contains(image, containerImage+":") |
There was a problem hiding this comment.
q: Is this gofmt compliant? just curious
| crd := &apiextensionsv1.CustomResourceDefinition{} | ||
| if err := k8syaml.Unmarshal(doc, crd); err != nil { | ||
| // Skip non-CRD documents (e.g., comments) | ||
| continue | ||
| } |
There was a problem hiding this comment.
q: interesting! this is a new way of parsing using k8syaml right?
There was a problem hiding this comment.
No, it's nothing new. It came as same approach used in by other kube projects.
see https://github.com/kubernetes-sigs/controller-runtime/blob/679fb347b532c2278ee0e30469e322c96b75c091/pkg/envtest/crd.go#L424
josvazg
left a comment
There was a problem hiding this comment.
q: is this properly disabled for now?
No, I raised the question about put PR on hold vs feature flag. |
IMO we should make this an experimental feature only enabled with a compile time flag. Similar to the experimental support already have in the AKO repo. If you agree I could setup that up in a separate PR and let you rebase on top later. We will basically need to compile with a flag to get the experimental features and this would we one of them. we could try the UX manually or run e2e tests that leverage it. |
70ee936 to
82def59
Compare
Proposed changes
This PR introduces support for exporting Atlas resources using auto-generated CRDs.
Important notes
Jira ticket: CLOUDP-356692
Checklist
make fmtand formatted my code