PYTHON-5668 - Merge backpressure branch into mainline

[NoahStapp]

PYTHON-5668

Changes in this PR

Merge backpressure branch into master.

Reviewers can ignore all spec test changes. Focus on the actual code changes within pymongo/ and the prose tests.

Test Plan

Checklist

Checklist for Author

• Did you update the changelog (if necessary)?
• Is there test coverage?
• Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

• Does the title of the PR reference a JIRA Ticket?
• Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
• Is all relevant documentation (README or docstring) updated?

[Copilot]

Pull request overview

Copilot reviewed 54 out of 55 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 54 out of 55 changed files in this pull request and generated 6 comments.

[aclark4life]

Could this ^ be error.has_error_label("RetryableError") with an isinstance(error, PyMongoError) guard?

[NoahStapp]

Can you expand on what this if statement would look like with that change?

[aclark4life]

  retryable_label_error = (                                                                                                                                        
      isinstance(error, PyMongoError)
      and error.has_error_label("RetryableError")                                                                                                                  
  )       

[NoahStapp]

Good catch, that is a clarity and consistency improvement.

[Copilot]

Pull request overview

Copilot reviewed 52 out of 53 changed files in this pull request and generated 3 comments.

[aclark4life]

Suggest minor improvement to conditional clarity via additional parenthesis wrapping the outer or condition:

  if (                                                                                                                                
      not self._client.options.retry_reads                                                                                          
      or (                                                                                                                            
          not always_retryable
          and (                                                                                                                       
              self._is_not_eligible_for_retry()                                                                                     
              or (
                  isinstance(exc, OperationFailure)
                  and exc_code not in helpers_shared._RETRYABLE_ERROR_CODES
              )                                                                                                                       
          )
      )                                                                                                                               
  ):             

[aclark4life]

Already inside if overloaded

[aclark4life]

LGTM! 🎉

[sleepyStick]

phew big PR -- sorry it took me a hot minute to review it, i've been looking at bits of it throughout the day (between workloads lol ;-;) just one change but otherwise its good! Great work!

[sleepyStick]

i think PYTHON-5668.patch can be removed too?

[NoahStapp]

Good catch! At long last

[sleepyStick]

woo!!! one step closer to being done with backpressure!