DRIVERS-3239 - Token buckets disabled by default#1902
Merged
NoahStapp merged 8 commits intomongodb:client-backpressurefrom Mar 3, 2026
Merged
DRIVERS-3239 - Token buckets disabled by default#1902NoahStapp merged 8 commits intomongodb:client-backpressurefrom
NoahStapp merged 8 commits intomongodb:client-backpressurefrom
Conversation
NoahStapp
requested review from
ShaneHarvey,
katcharov and
stIncMale
and removed request for
a team
tadjik1
reviewed
Feb 24, 2026
Member
tadjik1
left a comment
tadjik1
left a comment
There was a problem hiding this comment.
Small typos in SystemOverloaded error label (must be lowercased).
Draft
5 tasks
tadjik1
reviewed
Feb 24, 2026
Member
|
2nd implementation in Node: mongodb/node-mongodb-native#4878 |
Co-authored-by: Sergey Zelenov <mail@zelenov.su>
Co-authored-by: Sergey Zelenov <mail@zelenov.su>
tadjik1
approved these changes
Feb 24, 2026
stIncMale
requested changes
Feb 25, 2026
Member
stIncMale
left a comment
stIncMale
left a comment
There was a problem hiding this comment.
The last reviewed commit is 3eec81c.
I reviewed only client-backpressure.md. I do not plan to review the changes in prose tests, because the Java driver does not have the backpressure implementation I could try the tests with.
ShaneHarvey
reviewed
Feb 25, 2026
| 3. Configure the following failpoint: | ||
|
|
||
| ```` | ||
| ```javascript |
Member
There was a problem hiding this comment.
This section renders incorrectly because of the nested ````
| Drivers should test that retry token buckets are created at their maximum capacity and that that capacity is enforced. | ||
|
|
||
| 1. Let `client` be a `MongoClient`. | ||
| 1. Let `client` be a `MongoClient` with `adaptiveRetries=True`. |
Member
There was a problem hiding this comment.
Do we also need to update the spec tests to add adaptiveRetries=True?
Contributor
Author
There was a problem hiding this comment.
No, none of the spec tests test behavior involving token buckets.
NoahStapp
requested review from
JamesKovacs,
ShaneHarvey and
stIncMale
and removed request for
a team
ShaneHarvey
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python first implementation: mongodb/mongo-python-driver#2713.
Please complete the following before merging:
clusters).