DRIVERS-3427: Finalize client backpressure implementation for phase 1 rollout#1919
Merged
dariakp merged 14 commits intomongodb:masterfrom Apr 10, 2026
Merged
DRIVERS-3427: Finalize client backpressure implementation for phase 1 rollout#1919dariakp merged 14 commits intomongodb:masterfrom
dariakp merged 14 commits intomongodb:masterfrom
Conversation
Co-authored-by: Isabel Atkinson <isabelatkinson@gmail.com>
Co-authored-by: Isabel Atkinson <isabelatkinson@gmail.com>
stIncMale
previously requested changes
Apr 2, 2026
stIncMale
reviewed
Apr 2, 2026
Contributor
|
Rust second implementation: mongodb/mongo-rust-driver#1654 |
isabelatkinson
approved these changes
Apr 2, 2026
jyemin
approved these changes
Apr 6, 2026
connorsmacd
approved these changes
Apr 7, 2026
stIncMale
reviewed
Apr 10, 2026
dariakp
approved these changes
Apr 10, 2026
Feedback has been incorporated within the constraints of the design decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the client backpressure specification and related specifications to align with the finalized backpressure retry policy.
A summary of these changes with brief reasonings:
MAX_RETRIESnow defaults to 2 rather than 5. Without token buckets, retry storms occur much more easily. Lowering the default number of maximum retries reduces this risk while still alleviating server overload.primaryPreferredandsecondaryPreferredcause semantic differences that we want users to explicitly opt-in to.maxAdaptiveRetries, which configuresMAX_RETRIES, andenableOverloadRetargeting, which enables overload retargeting for non-sharded servers. Both are configurable as both client and URI options.Please complete the following before merging:
clusters).