This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Add @cache to Moped::Cursor for out-of-block iteration#238
Open
fancyremarker wants to merge 1 commit intomongoid:masterfrom
Open
Add @cache to Moped::Cursor for out-of-block iteration#238fancyremarker wants to merge 1 commit intomongoid:masterfrom
fancyremarker wants to merge 1 commit intomongoid:masterfrom
Conversation
The Mongo Ruby driver (and thus Mongoid 2.x) supported iterating over a
cursor outside a block, using such operations as take(). For example:
batch_size = 10
cursor = session[:users].find({}).cursor
while (users = cursor.take(batch_size)).present?
# Do stuff...
end
# Do more stuff...
This was a convenient pattern for implementing lots of algorithms in a
more readable way than if they were written using each().
Contributor
|
@fancyremarker looks like Travis build failed, not sure if this is introduced by this change |
Author
|
@dblock: I couldn't see how it was connected, but that's because of my own ignorance. FWIW, specs did pass locally for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveat: This is potentially very risky, so feel free to reject. I'm not familiar enough with Mongoid to understand all the implications of this change. That said, we've been using it in production for some time without any apparent ill effects.
The Mongo Ruby driver (and thus Mongoid 2.x) supported iterating over a cursor outside a block, using such operations as take(). For example:
This was a convenient pattern for implementing lots of algorithms in a more readable way than if they were written using each(). This patch reintroduces this convenience.
cc: @dblock