This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Failover authentication fixes#311
Closed
thijsc wants to merge 2 commits intomongoid:masterfrom
appsignal:failover_auth_fix
Closed
Failover authentication fixes#311thijsc wants to merge 2 commits intomongoid:masterfrom appsignal:failover_auth_fix
thijsc wants to merge 2 commits intomongoid:masterfrom
appsignal:failover_auth_fix
Conversation
When the replica set is reconfigured or a node is in startup mode this can cause authentication errors. We now use the Retry failover strategy in this case so we try again and mark the node as down if the operation fails again.
|
I think your pull-request won't fix the issue here, as failover mechanism for authentication issues is not executed, because: Node#flush is sending operations to database in ensure_connected block, which handles failover. However processing of messages returned by database is outside of I've opened a pull-request, which I believe fixes failover/retries issues here: #320 |
|
Looking at it |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull fixes an issue we've been experiencing in production because a replica set failover can trigger authentication failures. For these failures the Ignore strategy was used, which doesn't mark the node as down. Moped then keeps trying to authenticate with this node in down state which stalls the entire system.
In this pull the strategy for
AuthenticationFailureis switched toRetryand we also mark a node as down when there's an authentication failure in the read operation. This behavior is similar to what was in place before 6f211ac. These changes (mostly) fix the issues we had during failover.