feat(webhooks): add Linear webhook info to webhooks dashboard and CLI tool#1108
feat(webhooks): add Linear webhook info to webhooks dashboard and CLI tool#1108
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — Clean, well-structured addition of Linear webhook informational display to the webhooks dashboard and CLI. The implementation correctly follows the existing Sentry pattern (informational-only, no programmatic creation/deletion), with consistent changes across all layers: types, context resolution, one-time token support, API router, CLI commands, and the standalone setup-webhooks tool. Tests are thorough with 196 new lines covering all key scenarios.
A few observations (none blocking):
-
The
errorsobject now includeslinear: null(always hardcoded null), whereas the analogous Sentry info has no entry inerrorsat all. This is a minor inconsistency but arguably better — it provides explicit typing for clients that enumerate the errors object. -
The
tools/setup-webhooks.tstool conditionally warns about missing Trello creds only whenpmType === 'trello', which is a nice improvement over the previous unconditional warning for non-Trello projects. -
CI is all green — lint, typecheck, unit tests (7488), integration tests, and Docker builds all pass.
🕵️ claude-code · claude-opus-4-6 · run details
Summary
LinearWebhookInfotype towebhooks/types.ts(same shape asSentryWebhookInfo)linearApiKeyandlinearWebhookSecretSettoProjectContextinwebhooks/types.tsresolveProjectContext()to populatelinearApiKey/linearWebhookSecretSetfrom credentialslinearApiKeytooneTimeTokensSchemaandapplyOneTimeTokens()for fresh credential passthroughwebhooks.listquery to returnlinear: LinearWebhookInfo | nulland includelinear: nullin errors objectwebhooks.createmutation to return informationallinear: LinearWebhookInfo(display-only, no actual creation)LinearWebhookInfofromwebhooks.tswebhooks listcommand to display Linear webhook infowebhooks createcommand to display Linear manual setup instructionstools/setup-webhooks.tsto show Linear webhook URL and manual setup instructions inlistandcreatecommandsTest plan
LinearWebhookInfotype defined correctlyProjectContextincludeslinearApiKeyandlinearWebhookSecretSetfieldsoneTimeTokensSchemaincludeslinearApiKeyapplyOneTimeTokensapplieslinearApiKeyoverridelistreturnslinearwebhook info whenpmType === 'linear'andlinearApiKeyis setlistreturnsnullwhen nocallbackBaseUrlor nolinearApiKeylisterrors object includeslinear: nullcreatereturnslinearwebhook info for Linear PM projectscreatedoes NOT returnlinearinfo for non-Linear projectsTrello card: https://trello.com/c/69deb0e780e6f5a20d70f6bb
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details