🐛 Make the Dependencies readiness check advisory instead of blocking - #117
Merged
Conversation
`develop` exited 1 when an issue body lacked a `## Dependencies` heading, even when the issue genuinely had no dependencies. The check is a heading regex that never inspects the section contents, so it gated on whether prepare/plan had run rather than on development readiness. - Add `advisory` to `CheckResult`; mark the dependencies check advisory - `_checks_passed()` ignores advisory checks for both the `validate` exit code and the `develop` pre-flight - Report renders a failing advisory check as `WARN` and tallies only blocking checks - Update the plan prompt, bundled skill, and README to match
monkut
commented
Jul 31, 2026
monkut
left a comment
Owner
Author
There was a problem hiding this comment.
increment uv.lock with appropriate version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
askcc developexited 1 when an issue body lacked a## Dependenciessection, even when the issue had no dependencies._has_dependencies_section()is a heading regex (## Dependencies|Prerequisites|Context|Blockers) that never inspects the section's contents. Theprepareandplanprompts instruct agents to always emit the heading — writing "None identified." when there are none — so the check gated on whether an agent had processed the issue, not on development readiness. Hand-written issues that skippedprepare/planhit an exit 1 whose message ("No dependencies/context section found") read as "you have unlisted dependencies".Change
The dependencies check still runs and still appears in the report — it just no longer affects an exit code.
CheckResultgainsadvisory: bool = False(askcc/functions.py:306); the dependencies check setsadvisory=True._checks_passed()inaskcc/cli.pyignores advisory checks. Both gates use it: thevalidateexit code and thedeveloppre-flight._check_status()renders a failing advisory check asWARN; the report tallies blocking checks only.Issue with acceptance criteria + assignee, no
## Dependencies:Docs corrected
The
planagent prompt (askcc/definitions.py:173) and the bundledhandle-github-issueskill both asserted "developrejects the issue otherwise" for the Dependencies heading. Now scoped to acceptance criteria and assignee, with the heading described as advisory but still expected from a planned issue.SKILL.mdlabels each check blocking/advisory and its sample report showsWARN. README rows forvalidateand the gating mechanisms updated.Test plan
uv run pytest— 284 passed (3 new)uv run poe check— ruff cleantest_dependencies_check_is_advisory— only the dependencies check carriesadvisory=Truetest_validate_exits_zero_when_only_dependencies_missing— exit 0,[WARN]line,3/3 blocking checks passedtest_develop_proceeds_when_only_dependencies_missing— runner invoked despite the failing advisory checktest_validate_exits_one_on_failandtest_develop_fails_on_validation_failurestill fail as expected on blocking checksVersion bumped to 0.2.15.