feat: add post-develop verification before label transition - #75
Merged
Conversation
Gate the transition to action:review on passing project verification (tests, lint, type check). Detection-based approach tries common project commands from pyproject.toml, package.json, or Makefile. If no commands are detected, verification is skipped (don't block). Closes #69
The --cwd flag is defined on the main parser, so it must appear before the subcommand. All examples had it after, causing argparse to reject the command.
monkut
commented
Apr 9, 2026
Verification commands are now read from [tool.askcc.verify] in pyproject.toml or [[verify]] in .askcc.toml, making the feature language/framework agnostic. No auto-detection of specific tools.
Owner
Author
|
Addressed review feedback in 5bc05ed. Replaced all hardcoded language/tool detection with user-configured verification commands. Detection now reads from:
Example config (any language/framework): # pyproject.toml
[[tool.askcc.verify]]
name = "tests"
cmd = "uv run poe test"
[[tool.askcc.verify]]
name = "lint"
cmd = "uv run poe check"Or for non-Python projects via [[verify]]
name = "tests"
cmd = "npm test"
[[verify]]
name = "lint"
cmd = "npm run lint"If no config is found, verification is skipped (no blocking). All hardcoded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action:reviewpyproject.toml(poe tasks or direct tools),package.json(npm scripts), orMakefiletargetsVerification
uv run poe test— passed (114 tests)uv run poe check— passed (no issues)uv run poe typecheck— passed (0 errors)Test plan
Closes #69