🐛 Add test plan checklist update to develop prompt (closes #88) - #90
Merged
Conversation
Mirrors REVIEWPR_AGENT_PROMPT's read -> mark -> edit flow so the develop action checks off PR test plan items it has already satisfied via the implementation, new tests, and verification gate, leaving manual/external items unchecked.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEVELOP_AGENT_PROMPT's "On completion" block (between PR push and issue comment).REVIEWPR_AGENT_PROMPT, with explicit carveouts for manual/external verification items and a silent no-op when no## Test plansection exists.TestDevelopPromptTestPlanUpdatetotests/test_askcc.py(betweenTestDevelopPromptTddContentandTestReviewprPromptMergeGuard) with literal-substring assertions on the new wording, mirroring theTestReviewprPromptMergeGuardprecedent.Key Flows
flowchart TD A[develop completes] --> B[run /simplify or /refactor] B --> C[commit & push branch] C --> D[open PR linked to issue] D --> E{Test plan section present?} E -- no --> G[skip silently] E -- yes --> F[mark satisfied items - x , leave manual items - blank] F --> H[gh pr edit --body updated] G --> I[add issue comment summary] H --> IVerification
uv run pytest— passed (192 tests)uv run ruff check— passed (no issues)uv run pyright— passed (0 errors, 0 warnings)Test plan
DEVELOP_AGENT_PROMPTinstructs the agent to update test plan items in the PR description after PR creation## Test plansection existsDEVELOP_AGENT_PROMPTuv run pytest,uv run ruff check, anduv run pyrightall pass