🐛 Forbid linter/type-checker config relaxation in develop and fix-ci prompts (closes #89) - #91
Merged
Merged
Conversation
…prompts (closes #89) Add a `Configuration boundaries` section to both DEVELOP_AGENT_PROMPT and FIXCI_AGENT_PROMPT that explicitly forbids modifying linter, formatter, or type-checker configuration files (and inline suppression comments) to silence errors. The wording is shared via a `CONFIG_BOUNDARIES_BODY` constant so the two prompts stay in sync.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #89.
Configuration boundariessection to bothDEVELOP_AGENT_PROMPTandFIXCI_AGENT_PROMPT(askcc/definitions.py) that explicitly forbids modifying linter/formatter/type-checker config files (pyproject.toml [tool.ruff]/[tool.pyright]/[tool.mypy],.ruff.toml,pyrightconfig.json,mypy.ini,.pre-commit-config.yaml, ESLint/Prettier configs) or adding inline suppression comments (# noqa,# type: ignore,# pyright: ignore,eslint-disable) to silence errors.CONFIG_BOUNDARIES_BODYconstant (composed intoDEVELOP_CONFIG_BOUNDARIESwith the prose-style heading used byDEVELOP_AGENT_PROMPT, and intoFIXCI_CONFIG_BOUNDARIESwith the## Sectionheading used byFIXCI_AGENT_PROMPT) so the two prompts cannot drift.TestConfigBoundaryConstraints(9 tests) intests/test_askcc.pyasserting that both prompts contain the heading, the listed config files, the forbidden suppression comments, and the documented exceptions — plus a placement check thatConfiguration boundariesprecedes## Fixing Failuresin the fix-ci prompt.No runtime/API/schema changes — only the prompt strings sent to downstream Claude agents are modified.
Verification
uv run pytest— passed (195 tests, including the 9 newTestConfigBoundaryConstraintstests)uv run ruff check— passed (no issues)uv run pyright— passed (0 errors, 0 warnings)Test plan
uv run pytestpassesuv run ruff checkpassesuv run pyrightpassesTestConfigBoundaryConstraintstest class covers develop + fix-ci prompts