chore: add AI PR Review to github-workflows self-CI#280
Closed
JesperTerkelsen wants to merge 1 commit intomainfrom
Closed
chore: add AI PR Review to github-workflows self-CI#280JesperTerkelsen wants to merge 1 commit intomainfrom
JesperTerkelsen wants to merge 1 commit intomainfrom
Conversation
Drops in the same shared workflow we use across the Kotlin/TS service repos (service-control, service-vehicle, service-api-gateways, etc.) so PRs to this repo also get an automated AI code review. Same pattern as service-vehicle and service-api-gateways: - Triggers on opened, ready_for_review, synchronize, and issue_comment - Delegates to monta-app/ai-standards/.github/workflows/ai-pr-review.yml@main - Uses the org-level ANTHROPIC_API_KEY + AI_REVIEWER_SECRET_KEY secrets Sets run-on-drafts: true so reviews fire on draft PRs as well — useful for this repo specifically because changes here usually start as drafts while we test against downstream service repos before promoting. The actionlint check in pull-request.yml already covers static workflow syntax; this layers a content/intent review on top, which is useful for a repo where every change ripples to every Monta service.
b2a9046 to
b30ff52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the same
AI PR Reviewworkflow we run on the service repos (service-control,service-vehicle,service-api-gateways, etc.) to this repo's own self-CI, so PRs against the shared workflows also get an automated code review.Why here too
This repo's CI currently only runs
actionlint(syntactic). Every change here ripples to every Monta service that consumes the shared workflows, so an extra layer of intent/content review on top ofactionlinthas obvious value:--max-workers=2discussion on ci: add optional openapi-max-workers input to component-service-profile-kotlin #279 that prompted this)What it adds
A single new file:
.github/workflows/ai-pr-review.yml. Pattern matchesservice-vehicleandservice-api-gatewaysplusrun-on-drafts: true:run-on-drafts: trueis intentional for this repo specifically — changes here usually start as drafts while we test against downstream service repos before promoting them. We want the AI review during that draft phase, not just after promotion.Prerequisites
The workflow expects
ANTHROPIC_API_KEYandAI_REVIEWER_SECRET_KEYsecrets to be available. If they're already configured at the org level (which is how the service repos pick them up), this should "just work" the moment the PR merges. If not, the org admin will need to grant this repo access to those secrets.Test plan
ai-review / AI Reviewcheck shows up and runs (not just on ready-for-review)🤖 Generated with Claude Code