ci: pass openapi-max-workers through deploy-kotlin{,-v2} to component-service-profile#281
Merged
JesperTerkelsen merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
…-service-profile Plumbs the new openapi-max-workers input added in #279 from the deploy-kotlin and deploy-kotlin-v2 umbrella workflows down into component-service-profile-kotlin where it actually maps to ./gradlew --max-workers. Without this passthrough the input is unreachable from any service repo, since service repos call the umbrella workflows (deploy-kotlin / deploy-kotlin-v2), not component-service-profile-kotlin directly. Defaults to empty (no behavior change for existing callers). The intended caller-side change is in service-api-gateways' deploy_*.yml workflows, where each one will pass openapi-max-workers: '2' to avoid the OOM in the Update Service Profile step (failing runs: 25171374143, 25236336830, 25236336844).
maoanran
approved these changes
May 4, 2026
joscdk
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forwards the
openapi-max-workersinput added in #279 from thedeploy-kotlinanddeploy-kotlin-v2umbrella workflows down intocomponent-service-profile-kotlin, where it actually maps to./gradlew --max-workers=<n>.Why this is needed
Without this passthrough, the input added in #279 is unreachable from any service repo. Service repos consume the umbrella workflows (
deploy-kotlin.yml/deploy-kotlin-v2.yml), notcomponent-service-profile-kotlin.ymldirectly:So the umbrella has to declare and forward the input.
Diff
Same shape in both
deploy-kotlin.ymlanddeploy-kotlin-v2.yml:update-service-profile: required: false type: boolean default: true description: 'Use generated openapi spec to generate linkerd service profile and update the service helm chart' + openapi-max-workers: + required: false + type: string + default: '' + description: | + Optional cap on Gradle parallelism for the OpenAPI build step in the + update-service-profile job. Forwarded to component-service-profile-kotlin. + Set to e.g. "2" on multi-module repos that OOM the runner during + concurrent kapt. Empty string keeps default behavior. ... update-service-profile: name: Update Service Profile ... uses: ./.github/workflows/component-service-profile-kotlin.yml with: service-identifier: ${{ inputs.service-identifier }} stage: ${{ inputs.stage }} gradle-module: ${{ inputs.gradle-module }} java-version: ${{ inputs.java-version }} + openapi-max-workers: ${{ inputs.openapi-max-workers }}Default is
''so existing callers see no behavior change.Caller-side change (separate PR in service-api-gateways)
After this lands, each
deploy_*.ymlinservice-api-gatewayswill gainopenapi-max-workers: '2'to avoid the OOM in theUpdate Service Profile / Build OpenAPI specstep (failing runs: 25171374143, 25236336830, 25236336844).Test plan
openapi-max-workers: '2'and theUpdate Service Profilejob stops OOMing🤖 Generated with Claude Code