This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Add the possibility to select just one date and clic Apply in ranged mode#32
Open
lemonlab wants to merge 1 commit intomonterail:masterfrom
lemonlab:select-one-single-day-with-ranged-true
Open
Add the possibility to select just one date and clic Apply in ranged mode#32lemonlab wants to merge 1 commit intomonterail:masterfrom lemonlab:select-one-single-day-with-ranged-true
lemonlab wants to merge 1 commit intomonterail:masterfrom
lemonlab:select-one-single-day-with-ranged-true
Conversation
There was a problem hiding this comment.
Here is a bug.
STR:
- Open selector, choose any date and click "Cancel"
- Open selector again and click "Apply". In console we'll see: "TypeError: Cannot read property 'clone' of null", window won't be closed.
- Select any date, click "Apply"
Expected result:
Value should be set to clicked date.
Actual result:
The same as it was before: Invalid date, calendar is broken etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code solve this issue :
The date is not changed.
If you click again on the datepicker, select one date, click apply, and open again the datepicker : there is bigger problem : the calendar is empty.
This code solve those issues.