Add US Virgin Islands zip codes#36
Open
jpalacio-assurance wants to merge 1 commit intomonterail:masterfrom
Open
Add US Virgin Islands zip codes#36jpalacio-assurance wants to merge 1 commit intomonterail:masterfrom
jpalacio-assurance wants to merge 1 commit intomonterail:masterfrom
Conversation
brodyhoskins
requested changes
Dec 9, 2023
Collaborator
brodyhoskins
left a comment
brodyhoskins
left a comment
There was a problem hiding this comment.
The data looks good, but I believe the correct :time_zone would be "America/Virgin" rather than "Canada/Halifax".
|
Based off Wikipedia’s timezone article, it looks like the canonical zone would be |
Collaborator
|
The Wikipedia link shows that I'd argue we should use the more specific time zone for accuracy. It's not farfetched to think that one may change over time and introduce inaccuracies. |
|
Feel free to also open a PR against https://github.com/suvie-eng/zip-codes/ I'm not wanting to create maintainer controversy - but until the maintainers here integrate all of these, I'd like to have a gem that is the most up to date. Best |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are examining zip codes like 00803, 00850 as part of our application and noticed these were not included in the data. We did research and it seems including these ZIP codes (US Virgin Islands) would help to complete the dataset.
Resolves: #35