Closed
Conversation
3954ec8 to
fe69e99
Compare
Merged
Contributor
|
This will be better covered by #173 which proposes always installing xdebug and xhprof, but only enabling them when a runtime flag is passed. We really don't want to be getting into a situation where we're having build time flags to add features. It helps no-one and possibly even leads to stale cache layer issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change to activate Xdebug via the docker build command.
This is the build command:
docker build -t moodlehq/moodle-php-apache:7.3 --build-arg XDEBUG=1 .
or
docker build -t moodlehq/moodle-php-apache:7.3-xdebug --build-arg XDEBUG=1 .
We can override the arguments:
docker build -t moodlehq/moodle-php-apache:7.3 --build-arg XDEBUG=1 --build-arg XDEBUG_REMOTE_HOST=0.0.0.0 --build-arg XDEBUG_VERSION=2.8.0 .
Thank you for your comments.
Ali