[python-pytrakt] Add show_id attribute to TVEpisode found from search#208
Open
simonc56 wants to merge 2 commits intomoogar0880:masterfrom
Open
[python-pytrakt] Add show_id attribute to TVEpisode found from search#208simonc56 wants to merge 2 commits intomoogar0880:masterfrom
simonc56 wants to merge 2 commits intomoogar0880:masterfrom
Conversation
This was referenced Oct 22, 2022
simonc56
force-pushed
the
get-show_id-from-episode-search
branch
from
3f75453 to
da02d95
Compare
glensc
added a commit
to glensc/python-pytrakt
that referenced
this pull request
Oct 23, 2022
Contributor
|
Carried to my fork: |
Contributor
|
@twolaw please prepend |
simonc56
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, to get the show of a TVEpisode we only have show name (
self.show) which is not reliable because some shows have the same name.The show trakt id is more reliable than show name because it is unique.
This PR adds
show_idattribute to TVEpisode built from search request and uses it in further API requests instead of slug built from show name.Example : Top Boy and Top Boy 2019
A TVEpisode from Top Boy 2019 uses slug
top-boy(made fromslugify(self.show)) instead oftop-boy-2019to fetch data from trakt api. Therefore data received is wrong.