Make DefaultProblem implement the error interface#1
Open
flynnguy wants to merge 2 commits intomoogar0880:masterfrom
Open
Make DefaultProblem implement the error interface#1flynnguy wants to merge 2 commits intomoogar0880:masterfrom
flynnguy wants to merge 2 commits intomoogar0880:masterfrom
Conversation
|
This could be very useful. I did something similar myself before finding this library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the Error() function to satisfy the error interface. Error string should be
<Title> (Status) - <Detail>I also had to modify badProblemType and badProblemTitle structs in the tests to add an Error() function. They currently return an empty string because those tests don't use it.