Fix wrapped UI text auto height - #49
Merged
Milky2018 merged 1 commit intoJul 22, 2026
Merged
Conversation
Collaborator
|
Thanks for the contribution. This was merged with an additional end-to-end regression covering the final computed node height, not only the leaf measurement helper. UI tests pass on the current Chicle backend, and the fix is available in Selene 0.37.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The leaf measure callback previously measured the full string as one line and ignored
TextLayout. Rendering then wrapped against the final content rect, so Taffy could record a 16px height while two 16px lines were drawn. The change keeps the existing text helpers in place and addsprepare_text_layoutas the shared orchestration layer. Taffy per-tree leaf measurement caching remains unchanged; no persistent cache is added.Fixes #48
Checks
moon check src/ui --target all --deny-warnmoon test src/ui --target native --release --deny-warn