fix: clamp UI scroll positions to content bounds - #51
Merged
Milky2018 merged 1 commit intoJul 22, 2026
Conversation
Collaborator
|
Thanks for the contribution. This was merged with the public surface kept minimal: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moon_taffyto 0.5.3 for correct container content-size aggregation and add regression coverage for resizing, overflow policy changes, and input deltas.ScrollPositionwas applied directly to child layout without an upper bound, while the previous layout dependency did not provide correct non-leaf content extents. This allowed content to move past its final scroll position and left stale offsets when layout sizes changed. The computed maximum and effective position now give layout, input, and future scrollbar rendering one consistent result.Fixes #50
Checks
moon check src/ui -dmoon test -p Milky2018/selene/ui -d(32 passed)