Conversation
Pull Request Test Coverage Report for Build 161Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the socket
bindoperation can be time-consuming sometimes, lasting for several dozen milliseconds. This is causing random test failure on the CI, due to long-runningbindmessing timer precision up. This PR makesbindoperations on socket async by running them in the thread pool. As a result,@socket.TcpServer::new,@socket.UdpServer::newand@http.Server::newbecome async as well, making this PR a breaking change.bindis not a very heavy operation, so running it in the thread pool may actually be slower in terms of delay. However,bindis usually not a frequent operation: most programs won't create a lot of servers simultaneously and repeatedly. So the rationale here is to trade delay for better scheduling fairness.