Open
Conversation
myfreess
force-pushed
the
add_myers_diff
branch
11 times, most recently
from
a42e404 to
526ff08
Compare
myfreess
force-pushed
the
add_myers_diff
branch
3 times, most recently
from
69ede8b to
ee4ded2
Compare
Collaborator
Pull Request Test Coverage Report for Build 3721Details
💛 - Coveralls |
myfreess
force-pushed
the
add_myers_diff
branch
12 times, most recently
from
24ca5ba to
b2c2311
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
myfreess
force-pushed
the
add_myers_diff
branch
3 times, most recently
from
f5f7227 to
88cd676
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
myfreess
force-pushed
the
add_myers_diff
branch
2 times, most recently
from
f8a7548 to
13bc2f7
Compare
Contributor
Author
|
@codex review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
myfreess
force-pushed
the
add_myers_diff
branch
from
70b8d61 to
bda110f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Users pattern-match Edit directly, making the separate EditTag enum and take_tagged_view_from method redundant indirection. Internal callers (render_with, test helper) now match on Edit variants inline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bundle source arrays with edit scripts so Edit values are always meaningful without passing old/new separately. Diff(old~, new~) is the entry point; .group(radius?) produces Array[Hunk[T]] with Show for unified-diff rendering. Also removes mut from Equal fields, makes grouping non-mutating, and drops deprecated Hunk::inner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…thm enum
Introduces pub(all) enum DiffAlgorithm { Myers; Patience } so the API
is extensible if more algorithms are added later.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Myers-based diff package to provide efficient sequence diffing, structured edit scripts, and hunk-level grouping for downstream diff-style output.