refactor(debug): convert pretty-print helpers to Repr methods#3284
Open
refactor(debug): convert pretty-print helpers to Repr methods#3284
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bobzhang
force-pushed
the
hongbo/refactor-debug-pretty-print
branch
2 times, most recently
from
05037ca to
be46fd3
Compare
Collaborator
Pull Request Test Coverage Report for Build 2887Details
💛 - Coveralls |
…plify - Merge `prune_repr_info` and `prune_info` into `Repr::prune_info` - Rename `pretty_print_repr_go` to `Repr::pretty_print` - Rename `render_repr` to `Repr::render_repr` - Inline `quote_string_literal` (just `s.escape()`) - Simplify `is_unquoted_key` using string pattern matching - Use `[first, ..rest]` destructuring with spread construction - Use `s is ['-',..]` pattern instead of index check for Integer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobzhang
force-pushed
the
hongbo/refactor-debug-pretty-print
branch
from
be46fd3 to
092d48d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prune_repr_infoandprune_infointo a singleRepr::prune_infomethod withmax_depth~ : Int?pretty_print_repr_gotoRepr::pretty_printandrender_reprtoRepr::render_reprquote_string_literal(was justs.escape()) and remove itis_unquoted_keyusing string pattern matching withissyntax[first, ..rest]destructuring with spread construction instead of manual slicings is ['-',..]pattern instead of index-based check for Integer sign detectionTest plan
moon checkpasses (pre-existing errors inbuiltinare unrelated)🤖 Generated with Claude Code