perf(sorted_set): optimize union and symmetric_difference#3311
Closed
perf(sorted_set): optimize union and symmetric_difference#3311
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Collaborator
Pull Request Test Coverage Report for Build 3071Details
💛 - Coveralls |
bobzhang
force-pushed
the
hongbo/sorted-set-optimize
branch
3 times, most recently
from
2a7be29 to
072c29d
Compare
union: replace full tree traversal for size counting with a direct count function, removing the TODO about avoiding size counting symmetric_difference: build result directly in a single pass instead of creating two intermediate sets then merging them Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobzhang
force-pushed
the
hongbo/sorted-set-optimize
branch
from
072c29d to
f3d1304
Compare
Contributor
Author
|
Closing in favor of #3315 which provides the genuinely algorithmic O(n+m) improvement. This PR's changes (count function, symmetric_difference rewrite) are superseded — the count function is the same O(n) as the original each-based approach, and #3315 rewrites symmetric_difference with the split-based algorithm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
each) for size counting with a direct recursivecountfunction. Removes the TODO comment.differencesets then callingunion. Removes the TODO comment.Test plan
moon checkpasses🤖 Generated with Claude Code