perf(hashset): fix from_array capacity and make shift_back iterative#3334
Open
perf(hashset): fix from_array capacity and make shift_back iterative#3334
Conversation
Collaborator
Pull Request Test Coverage Report for Build 3172Details
💛 - Coveralls |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
bobzhang
force-pushed
the
perf/hashset-capacity-and-shift-back
branch
from
20f6de6 to
7c4b0d1
Compare
- from_array: pre-allocate with capacity=arr.length()*2 instead of default capacity 8. This avoids multiple grow operations during construction (e.g., a 100-element array was triggering 5 consecutive grow cycles: 8->16->32->64->128->256). - shift_back: convert from recursive to iterative loop. With 81% load factor, pathological hash collision patterns could create deep probe sequences, making the recursive version vulnerable to stack overflow on large tables. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobzhang
force-pushed
the
perf/hashset-capacity-and-shift-back
branch
from
7c4b0d1 to
d2c77e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capacity=arr.length()*2instead of default capacity 8, avoiding multiple grow operations during construction.Test plan
moon test -p moonbitlang/core/hashset— all 65 tests pass🤖 Generated with Claude Code