refactor: make show implement one of the methods#3402
Draft
peter-jerry-ye wants to merge 2 commits intomainfrom
Draft
refactor: make show implement one of the methods#3402peter-jerry-ye wants to merge 2 commits intomainfrom
peter-jerry-ye wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
Note : it seems that this requires compiler fix for the display of errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to change the behavior of
Showso that it is purely for displaying. So there will not be special handling forStringorCharany more. As a result, theoutputandto_stringwould behave the same. Thus people only need to implement one of the methods.This PR also migrates some of the builtin types' implementations to
to_string, because useoutputwould forcefully upcastStringBuiderto&Logger, which will increase code in some cases.