Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 3720Details
💛 - Coveralls |
4ed6082 to
d073e26
Compare
d073e26 to
7dd03d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR needs upcoming compiler release to merge.
Summary
This PR migrates the JS-side
Int64/UInt64implementation to a BigInt-backed representation and removes the old manual{ hi, lo }emulation path.Concretely, this change:
BigIntsemanticsint64_js.mbt/int64_nonjs.mbtimplementation into a single intrinsic-basedbuiltin/int64.mbtBigInt::from_int64,BigInt::from_uint64,Int64::to_string,UInt64::to_string, andenv.nowto match the new representationDouble -> (U)Int64conversion logic with saturating runtime intrinsicsdouble_to_int64implementation for JS, Wasm, and Wasm GCbuiltin/moon.pkgtarget selectionMotivation
The main goal is to stop maintaining a separate hi/lo-based 64-bit emulation path on JS and align the implementation more closely
with the intrinsic model used on other backends.
This reduces target-specific duplication, simplifies the runtime boundary, and makes the behavior of 64-bit integer operations
easier to maintain going forward.
Compatibility
No intended public API changes.
There are also no
.mbtichanges in this branch, so this should be a refactoring from the package interface perspective.Testing