refactor: use Arc<Mutex<...>> for SectionCapture#1291
Draft
tonyfettes wants to merge 1 commit intomoonbitlang:mainfrom
Draft
refactor: use Arc<Mutex<...>> for SectionCapture#1291tonyfettes wants to merge 1 commit intomoonbitlang:mainfrom
tonyfettes wants to merge 1 commit intomoonbitlang:mainfrom
Conversation
|
Review changes with Changed Files
|
tonyfettes
force-pushed
the
haoxiang/refactor-section-capture
branch
from
dd4a3c2 to
aa4e681
Compare
tonyfettes
force-pushed
the
haoxiang/refactor-section-capture
branch
from
aa4e681 to
5dcf8cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactor the
SectionCapturepassing logic to useArc<Mutex<...>>, so that it is possible to move the stdout capturing task into a standalone coroutine/thread.Metadata