fix transl_match: advance idx in go_normal for char pattern wildcard#8
Open
cuiweixie wants to merge 1 commit intomoonbitlang:mainfrom
Open
fix transl_match: advance idx in go_normal for char pattern wildcard#8cuiweixie wants to merge 1 commit intomoonbitlang:mainfrom
cuiweixie wants to merge 1 commit intomoonbitlang:mainfrom
Conversation
In calculate_char_paths, the catch-all branch for char/range patterns must pass idx + 1 to go_normal, matching the other branches that bind normal_field at the current index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_char_paths, the catch-all branch for char/range patterns now passesidx + 1togo_normal, consistent with other branches that consume anormal_fieldat the current index.Test plan