fix: make config file parsing stricter and support config includes - #934
Closed
matchaxnb wants to merge 3 commits into
Closed
fix: make config file parsing stricter and support config includes#934matchaxnb wants to merge 3 commits into
matchaxnb wants to merge 3 commits into
Conversation
added 2 commits
July 20, 2026 03:42
- now support comments at the end of lines - trims values of their trailing whitespaces - refactor error handling in args and config so that all errors are caught at once (alas, uses a global var in the config module, but it's fair ig) - safer integer parsing (atoi is known to not care at all for errors)
Author
|
I'm aware my dialect of C is fragile, it's been a while since I've written significant C code, but I tried to be as idiomatic as possible. |
Author
|
Additionally, I caught a stray fd remaining open on the config files at the end of parsing and made sure to close it. |
Author
|
Finally: I added some tests fixtures, feel free to make that better, as of now it's a smoke test, very manual. |
- make config file parsing use a flag that passes around - bool -> void for the parse due to use of that flag - safer rtrim - updated moonlight.conf with a bit of docs to be explicit about parsing format
Author
|
gonna close and open a cleaner one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: make config file parsing stricter and support config includes
Purpose
The config option provably does not work, at least for the width, height, and fps parameters.
This adds a few things:
config_file_parsewill cause an error in the function instead of being silently ignored. Unhandled keys should not be toleratedconfig = /some/pathis included (i think it's necessary)