Skip to content

Conversation

@kixelated
Copy link
Collaborator

Same as #855 but fixed the Github Action. @emilsas I can't modify your PRs unless @qualabs enables "allow edits from maintainers".

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Walkthrough

The changes add explicit universal macOS support and related toolchain targets. The CI workflow adds a universal-apple-darwin target. flake.nix enables Darwin build targets "x86_64-apple-darwin" and "aarch64-apple-darwin" when on macOS. The build script (rs/libmoq/build.sh) detects universal builds, validates host OS, builds both x86_64 and aarch64 releases (and lipo‑combines libraries), preserves single-target cross‑compilation paths for other targets, adds a Linux aarch64 linker variable, and updates packaging logic and archive creation accordingly.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding universal macOS build support for libmoq.
Description check ✅ Passed The description references the related PR #855 and explains the context of the changes, relating to the pull request's intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated enabled auto-merge (squash) January 22, 2026 23:04
@kixelated kixelated merged commit afe5867 into main Jan 22, 2026
1 check passed
@kixelated kixelated deleted the libmoq-macos-universal branch January 22, 2026 23:07
@moq-bot moq-bot bot mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants