Conversation
Add hack/gen_moreh_vllm_presets.py to generate InferenceServiceTemplate Helm preset files from the preset list in a moreh-vllm container image. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hhk7734
requested review from
TaeSooRhee-moreh,
Copilot and
nulledge
and removed request for
Copilot
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new hack/ utility to generate InferenceServiceTemplate Helm preset templates for moreh-vllm based on the preset YAML filenames found inside a moreh-vllm container image.
Changes:
- Introduces
hack/gen_moreh_vllm_presets.pyto parse preset filename stems and emit corresponding*.helm.yamltemplates. - Encodes a small model registry (org/name/HF path + GPU-count overrides) to enrich generated metadata and compute resource requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hack/gen_moreh_vllm_presets.py to generate InferenceServiceTemplate Helm preset files from the preset list in a moreh-vllm container image.