Add deployment dependency: openssh-client#64
Open
197g wants to merge 1 commit intomoriturus:developfrom
Open
Conversation
This is necessary to utilize an ssh-key with the index repository. If no
ssh is found, libgit never offers the SSH credential option and the
server fails with:
no supported credential type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to utilize an ssh-key with the index repository. If no ssh is found, libgit never offers the SSH credential option¹ and the server fails with:
This enables dockerized deployments with an ssh key, such as Github's Deploy keys.
This change add ~10MB to the container's final size (130MB to 139MB).
¹Specifically, the function in
RemoteCallbacks::credentialsis called with a parameter denoting the set permissible authenticators. When no ssh is found the bit forCredentialType::SSH_KEYis disabled. Then subsequently ktra does not check for the ssh key parameter, here.