test(gpu): focus evidence lanes on behavioral coverage - #204
Merged
Conversation
morluto
marked this pull request as ready for review
August 11, 2026 08:17
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GPU evidence integrations accumulated tests that mirrored private helpers, repeated stronger end-to-end coverage, or required source edits whenever internal structure moved. That made the adapter lane slower and noisier without proportionally strengthening the contracts introduced around #131–#136.
This change refocuses those lanes on observable behavior: immutable artifact preservation, bounded imports, failed-attempt recovery, extraction outputs, public capture and capability services, MCP transport behavior, and provider compatibility boundaries. It removes 23 collected cases while retaining or strengthening the failure modes and compositions those issues depend on.
Approach
nvccand Nsight Compute requires the officialncu_reportinterface before a live lane can run.bundle_pathstest seam and keep provider-specific bundle bounds with the provider and importing service rather than the generic request model.Suggested review order: start with the application-owned capture tests and ownership changes, then review the adapter fixture reductions, and finish with the four small production cleanups.
Commands run
Results:
main(26.4% faster).main(5.4% faster) while adding nine application-level compositions.c18488992e313240166f588b9ee4da3e0de76004, including binary sidecar extraction and a successful Nsight counter capture.Compatibility
There are no public API, protocol, schema, or storage-format changes. The generic bundle request no longer carries a provider-specific Pydantic member limit; the importing service still enforces the hard 100-member boundary, and typed providers retain their stricter validation.
Compute Sanitizer, NVBench, and Nsight Compute received live NVIDIA evidence on this host. Triton and CuTe remain fixture/process-simulation backed in this change. The ROCm test uses a project-owned ROCm-shaped Perfetto fixture and does not claim native rocprofv3 PFTrace compatibility or AMD hardware proof.