Skip to content

test: remove implementation-coupled checks - #281

Merged
morluto merged 1 commit into
mainfrom
agent/remove-implementation-tests
Aug 9, 2026
Merged

test: remove implementation-coupled checks#281
morluto merged 1 commit into
mainfrom
agent/remove-implementation-tests

Conversation

@morluto

@morluto morluto commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

Remove tests that checked source layout, schema inventories, catalog wording, or synthetic tool selection rather than observable product contracts.

Keep the useful behavior checks at their owner boundaries:

  • use a local Streamable MCP server for the DeepWiki adapter tests, allowing removal of its production-only callTool hook;
  • check the source-audit workflow through its MCP response rather than its hard-coded constructor;
  • retain the executable runtime-contract command while removing its unreachable duplicate CLI route and service contract.

Persistence, ordering, side-effect, schema-upgrade, MCP schema/annotation, and real stdio-protocol tests remain.

Validation

  • make verify

Review order

  1. internal/deepwiki/client.go and internal/deepwiki/client_test.go
  2. Runtime-contract deletions across the app, CLI, and contracts packages
  3. Remaining test-only cleanup in the corpus and MCP server suites

@morluto
morluto marked this pull request as ready for review August 9, 2026 09:55
@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@morluto
morluto merged commit b5397f8 into main Aug 9, 2026
14 checks passed
@morluto
morluto deleted the agent/remove-implementation-tests branch August 9, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant