Support s3 log dirs in TensorboardLogger#3893
Open
hengoren wants to merge 2 commits intomosaicml:mainfrom
Open
Support s3 log dirs in TensorboardLogger#3893hengoren wants to merge 2 commits intomosaicml:mainfrom
hengoren wants to merge 2 commits intomosaicml:mainfrom
Conversation
6c0d053 to
1b89f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TensorboardLoggerPathand allows tensorboard to properly log to s3What issue(s) does this change relate to?
Fixes #3892
Before submitting
make testas outlined in CONTRIBUTING.md led to 28 failurespre-commiton your change? (see thepre-commitsection of prerequisites)Happy to get to the bottom of the tests and pre-commit hooks, but figured it'd be easier to open the PR first