Work complete#2
Open
AvigailGellis wants to merge 2 commits into
Open
Conversation
moshefidds
reviewed
Feb 22, 2024
Owner
moshefidds
left a comment
moshefidds
left a comment
There was a problem hiding this comment.
Great Job!!
Minor changes requested
| SatisfactionRate int not null constraint ck_ExpenseLedger_SatisfactionRate_must_be_between_1_and_4 check(SatisfactionRate between 1 and 4), | ||
| SatisfactionDesc as case SatisfactionRate when 1 then 'Gold' when 2 then 'Silver' when 3 then 'Bronze' when 4 then 'Copper' end persisted, | ||
| --AS I made the following constraint according to the instructions that Q: Would any of the sub-causes belong to multiple causes? A: No. But the data included duplicates so I had to take it out. | ||
| -- constraint u_ExpenseLedger_Cause_SubCause unique(Cause, SubCause) |
Owner
There was a problem hiding this comment.
My intention was to clarify that each sub-cause was only a "child" of one cause. I admit there was no intention for a unique constraint.
Can a check constraint be used that first five characters must match?
| end, | ||
| datetimefromparts(m.OlympicYear, 01, len(m.LastName), m.AgeofMedalist/8, len(m.Sport), 52, len(m.FirstName + m.LastName + m.OlympicLocation) * 10), | ||
| --It makes more sense for table to have an int column and the desc computed off of that. However, for this data then I had to do the opposite to get the correct results. | ||
| case when m.AgeofMedalist > 29 then 4 |
Author
|
Please see corrections and comments and let me know if there is anything else you would like changed. |
Owner
|
Awesome Job!!! |
Owner
And mark if appropriate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi here is the work for your biz scenario, sorry I only got to it today. Nice and detailes spec! Let me know of any corrections.