Skip to content

fix: resolve null assertion crashes and correct API mapping in Networ… #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhutomer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve null assertion crashes and correct API mapping in Networ… #1041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/platform_android/network_service_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,15 @@ class NetworkServiceImpl implements NetworkService {
.get(Uri.parse(FlutterConfig.get('BASE_URL') +
FlutterConfig.get('ACTUATOR_INFO_PATH')))
.timeout(const Duration(seconds: 3));
// if (response.statusCode == 200) {
// ActuatorInfo actuatorInfo =
// ActuatorInfo.fromJson(jsonDecode(response.body));
// versionInfo = actuatorInfo.build['version']!;
// }
if (response.statusCode == 200) {
ActuatorInfo actuatorInfo =
ActuatorInfo.fromJson(jsonDecode(response.body));
versionInfo = actuatorInfo.build['version']!;
versionInfo = actuatorInfo.build['version'] ?? 'Unknown';
}
} catch (e) {
debugPrint("Fetch actuator info failed $e");
Expand Down Expand Up @@ -83,7 +88,7 @@ class NetworkServiceImpl implements NetworkService {
} on PlatformException {
debugPrint('SaveVersionToGlobalParam Api Call Failed');
} catch (e) {
debugPrint('Save version failed: $e');
debugPrint('Save screen header failed: $e');
}
return response;
}
Expand Down