Skip to content

[MOSIP-42820] prechecks enabled and severbaseurl #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanmeneges wants to merge 6 commits into from
Closed

[MOSIP-42820] prechecks enabled and severbaseurl #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e932f94
[MOSIP-42820] prechecks enabled and severbaseurl
Ivanmeneges Nov 26, 2025
7dd9d3f
Update push_trigger.yml
Ivanmeneges Nov 26, 2025
8a89695
Update build-android.yml
Ivanmeneges Nov 26, 2025
da3e025
Updated Npm dependencies push_trigger.yml
Ivanmeneges Nov 26, 2025
011f535
removed npm install
Ivanmeneges Nov 26, 2025
a11c082
Updated Npm dependencies push_trigger.yml
Ivanmeneges Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Build Android Registration-Client

on:
workflow_dispatch:
inputs:
inputs:
serverBaseURL:
description: "Enter serverBaseURL for APK"
required: true
Expand Down
23 changes: 16 additions & 7 deletions .github/workflows/push_trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ on:
- "sprint-*"

jobs:
codeql:
codeql:
name: CodeQL Security Analysis
runs-on: ubuntu-latest
permissions:
contents: read
security-events: write

steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -36,17 +36,21 @@ jobs:
languages: "java"

- name: Build for CodeQL
run: ./gradlew build || true
run: |
cd client
chmod +x gradlew
./gradlew build || true

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3

build:
name: Android Build Check
runs-on: ubuntu-latest
needs: [codeql]
needs: [codeql]
steps:
- uses: actions/checkout@v3
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Java 17
uses: actions/setup-java@v3
Expand All @@ -69,9 +73,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Inconsistent action versions across workflow.

The workflow uses different versions of actions/checkout: v2 (line 75) vs v3 (lines 31, 53). Standardize to v3 or later for consistency and security.

Apply this diff to update line 75:

-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3

Also applies to: 53-53, 31-31

🧰 Tools
🪛 actionlint (1.7.8)

75-75: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents 
.github/workflows/push_trigger.yml lines 31, 53, and 75: the workflow mixes
actions/checkout@v2 (line 75) with @v3 (lines 31 and 53); update the checkout
action at all three lines to use actions/checkout@v3 (or a newer stable major
version) so the workflow uses a consistent, up-to-date version across the file.

- name: Install npm dependencies
- name: Check repo structure
run: |
npm install
echo "Listing files:"
ls -R .

- name: Install npm dependencies
working-directory: client
run: npm install
- name: Updating serverBaseURL.
run: |
find . -type f -name "*build.gradle" -print0 | xargs -0 sed -i "s/api-internal.sandbox.xyz.net/${{ github.event.inputs.defaultServerBaseURL }}/g"
Expand Down