Skip to content

[MOSIP- 42820] Update Gradle commands in push_trigger.yml #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanmeneges wants to merge 1 commit into from
Closed

[MOSIP- 42820] Update Gradle commands in push_trigger.yml #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/push_trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: |
cd client
chmod +x gradlew
./gradlew compileDebugSources || true
./gradlew assembleDebug

- name: Run CodeQL Analysis
uses: github/codeql-action/analyze@v3
Expand All @@ -61,7 +61,7 @@ jobs:
run: |
cd client
chmod +x gradlew
./gradlew clean assembleDebug --dry-run
./gradlew tasks --all > /dev/null
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Replace task listing with actual validation.

The step name is "Validate Gradle Build" but the new command ./gradlew tasks --all > /dev/null only enumerates available tasks without performing any validation. The previous command ./gradlew clean assembleDebug --dry-run used --dry-run to validate the task execution graph without a full build.

Simply listing tasks does not catch build configuration errors, missing dependencies, or task graph issues. This undermines the purpose of the pre-build validation step and could allow broken builds to proceed to the APK build stage.

Apply this diff to restore validation semantics:

- ./gradlew tasks --all > /dev/null
+ ./gradlew tasks --all
+ ./gradlew clean assembleDebug --dry-run

Or, if the intent is a lightweight check, clarify the step purpose and rename it accordingly (e.g., "Verify Gradle Installation" or "List Build Tasks").

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
./gradlew tasks --all > /dev/null
./gradlew tasks --all
./gradlew clean assembleDebug --dry-run


build-apk:
name: Build APK
Expand All @@ -77,14 +77,13 @@ jobs:
- name: Replace serverBaseURL
run: |
find . -type f -name "*build.gradle" -print0 | \
xargs -0 sed -i "s|api-internal.sandbox.xyz.net|${{ github.event.inputs.serverBaseURL }}|g"
xargs -0 -r sed -i "s|api-internal.sandbox.xyz.net|${{ github.event.inputs.serverBaseURL }}|g"

- name: Build APK
run: |
cd client
chmod +x gradlew
./gradlew assembleDebug
ls app/build/outputs/apk/debug

- name: Upload APK
uses: actions/upload-artifact@v4
Expand Down